Skip to content

Conversation

@msailes
Copy link
Contributor

@msailes msailes commented Jul 9, 2021

Issue #, if available:
#207

Description of changes:
This is a little complex due to the various different modes of operation around REST and HTTP APIs, with the old (v1) and new (v2) message formats.

  • REST APIs should use APIGatewayProxyRequestEvent a version won't be set. This doesn't cause a problem, but getVersion() does return a null.
  • HTTP APIs using v1 and the APIGatewayProxyRequestEvent will have "1.0" set for the version.
  • HTTP APIs using v2 and the APIGatewayProxyRequestEvent will have "2.0" set for the version.
  • HTTP APIs using v2 should use the APIGatewayV2HTTPEvent to take advantage of the changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@msailes msailes self-assigned this Jul 9, 2021
@msailes
Copy link
Contributor Author

msailes commented Jul 9, 2021

I've tested all these variations on AWS.

Copy link
Contributor

@carlzogh carlzogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlzogh carlzogh merged commit 084fd86 into aws:master Aug 26, 2021
@msailes msailes deleted the missing-version-field branch August 6, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants